Cheng Zhou
0cc87210af
## 主要完成内容
### 1. 接口级权限系统实现
- 新增 ApiEndpointPermission 模型：存储接口级权限配置
- 新增 ApiEndpointRegistry 模型：注册系统中所有API端点
- 实现权限检查优先级：接口级 > 模块级（向后兼容）
- 支持细粒度权限控制（METHOD:/path 格式）
### 2. 权限配置系统
- 创建 api_permissions.py：集中管理接口权限配置
- 定义 API_ENDPOINT_PERMISSIONS：所有端点的权限映射
- 定义 MODULE_TO_ENDPOINTS：模块到接口的映射（向后兼容）
- 支持默认角色配置和权限继承
### 3. 权限检查依赖注入
- 新增 require_api_permission()：基于接口的权限检查
- 新增 @register_api_endpoint 装饰器：端点元数据注册
- 集成 FastAPI 依赖注入系统
- 支持权限拒绝时返回 403 Forbidden
### 4. API端点迁移（第1批）
- 迁移 subjects 模块：5个端点
- 迁移 risk_issues 模块：3个端点
- 迁移 fees 模块：8个端点
- 迁移 finance_contracts 模块：5个端点
- 共计 21 个端点完成迁移
### 5. 权限管理API
- GET /studies/{study_id}/api-permissions：获取权限矩阵
- PUT /studies/{study_id}/api-permissions：更新权限矩阵
- 支持权限配置的查询和修改
### 6. 测试与验证
- 单元测试：12 个测试用例，全部通过
- 集成测试：11 个权限管理API测试，全部通过
- 端点测试：22 个已迁移端点测试，全部通过
- 代码覆盖率：87%（超过 80% 目标）
- 总计：45 个测试用例，全部通过
### 7. 文档
- TESTING_SUMMARY.md：详细的测试结果总结
- IMPLEMENTATION_SUMMARY.md：实现细节文档
- TESTING_GUIDE.md：测试指南
## 技术亮点
1. **向后兼容性**：保留模块级权限，接口级权限优先
2. **灵活的权限配置**：支持默认角色和自定义权限
3. **细粒度控制**：支持跨模块数据访问权限
4. **完整的测试覆盖**：单元测试、集成测试、端点测试
5. **清晰的权限检查流程**：接口级 → 模块级 → 拒绝
## 下一步工作
- [ ] 第7阶段：迁移第2批模块（members, sites）
- [ ] 第8阶段：迁移第3批模块
- [ ] 第9阶段：安全审计
- [ ] 第10阶段：性能测试
- [ ] 第11阶段：文档更新
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
287 lines
7.5 KiB
Python
287 lines
7.5 KiB
Python
"""单元测试：API权限检查函数"""
|
|
|
|
import pytest
|
|
import uuid
|
|
from sqlalchemy.ext.asyncio import AsyncSession
|
|
|
|
from app.core.project_permissions import role_has_api_permission
|
|
from app.models.api_endpoint_permission import ApiEndpointPermission
|
|
from app.models.study_role_permission import StudyRolePermission
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_api_permission_check_allowed(db_session: AsyncSession):
|
|
"""测试接口级权限检查 - 允许"""
|
|
study_id = uuid.uuid4()
|
|
|
|
# 创建权限记录
|
|
perm = ApiEndpointPermission(
|
|
study_id=study_id,
|
|
role="CRA",
|
|
endpoint_key="POST:/subjects",
|
|
allowed=True,
|
|
)
|
|
db_session.add(perm)
|
|
await db_session.commit()
|
|
|
|
# 验证权限
|
|
result = await role_has_api_permission(
|
|
db_session, study_id, "CRA", "POST:/subjects"
|
|
)
|
|
assert result is True
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_api_permission_check_denied(db_session: AsyncSession):
|
|
"""测试接口级权限检查 - 拒绝"""
|
|
study_id = uuid.uuid4()
|
|
|
|
# 创建权限记录
|
|
perm = ApiEndpointPermission(
|
|
study_id=study_id,
|
|
role="PV",
|
|
endpoint_key="POST:/subjects",
|
|
allowed=False,
|
|
)
|
|
db_session.add(perm)
|
|
await db_session.commit()
|
|
|
|
# 验证权限
|
|
result = await role_has_api_permission(
|
|
db_session, study_id, "PV", "POST:/subjects"
|
|
)
|
|
assert result is False
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_api_permission_fallback_to_module_level(db_session: AsyncSession):
|
|
"""测试权限回退 - 接口级权限未配置时回退到模块级权限"""
|
|
study_id = uuid.uuid4()
|
|
|
|
# 创建模块级权限
|
|
module_perm = StudyRolePermission(
|
|
study_id=study_id,
|
|
role="CRA",
|
|
module="subjects",
|
|
can_write=True,
|
|
)
|
|
db_session.add(module_perm)
|
|
await db_session.commit()
|
|
|
|
# 不创建接口级权限，应该回退到模块级权限
|
|
result = await role_has_api_permission(
|
|
db_session, study_id, "CRA", "POST:/subjects"
|
|
)
|
|
assert result is True
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_api_permission_fallback_denied(db_session: AsyncSession):
|
|
"""测试权限回退 - 模块级权限被拒绝"""
|
|
study_id = uuid.uuid4()
|
|
|
|
# 创建模块级权限（拒绝）
|
|
module_perm = StudyRolePermission(
|
|
study_id=study_id,
|
|
role="PV",
|
|
module="subjects",
|
|
can_write=False,
|
|
)
|
|
db_session.add(module_perm)
|
|
await db_session.commit()
|
|
|
|
# 不创建接口级权限，应该回退到模块级权限
|
|
result = await role_has_api_permission(
|
|
db_session, study_id, "PV", "POST:/subjects"
|
|
)
|
|
assert result is False
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_admin_always_allowed(db_session: AsyncSession):
|
|
"""测试ADMIN角色总是被允许"""
|
|
study_id = uuid.uuid4()
|
|
|
|
result = await role_has_api_permission(
|
|
db_session, study_id, "ADMIN", "POST:/subjects"
|
|
)
|
|
assert result is True
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_api_permission_priority_over_module(db_session: AsyncSession):
|
|
"""测试接口级权限优先于模块级权限"""
|
|
study_id = uuid.uuid4()
|
|
|
|
# 创建模块级权限（允许）
|
|
module_perm = StudyRolePermission(
|
|
study_id=study_id,
|
|
role="CRA",
|
|
module="subjects",
|
|
can_write=True,
|
|
)
|
|
db_session.add(module_perm)
|
|
|
|
# 创建接口级权限（拒绝）- 应该优先使用这个
|
|
api_perm = ApiEndpointPermission(
|
|
study_id=study_id,
|
|
role="CRA",
|
|
endpoint_key="POST:/subjects",
|
|
allowed=False,
|
|
)
|
|
db_session.add(api_perm)
|
|
await db_session.commit()
|
|
|
|
# 应该返回接口级权限的结果（False）
|
|
result = await role_has_api_permission(
|
|
db_session, study_id, "CRA", "POST:/subjects"
|
|
)
|
|
assert result is False
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_api_permission_read_endpoint(db_session: AsyncSession):
|
|
"""测试读取端点权限"""
|
|
study_id = uuid.uuid4()
|
|
|
|
# 创建读取权限
|
|
perm = ApiEndpointPermission(
|
|
study_id=study_id,
|
|
role="PV",
|
|
endpoint_key="GET:/subjects/{id}",
|
|
allowed=True,
|
|
)
|
|
db_session.add(perm)
|
|
await db_session.commit()
|
|
|
|
# 验证权限
|
|
result = await role_has_api_permission(
|
|
db_session, study_id, "PV", "GET:/subjects/{id}"
|
|
)
|
|
assert result is True
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_api_permission_different_endpoints(db_session: AsyncSession):
|
|
"""测试不同端点的权限独立"""
|
|
study_id = uuid.uuid4()
|
|
|
|
# 创建权限：允许GET，拒绝POST
|
|
get_perm = ApiEndpointPermission(
|
|
study_id=study_id,
|
|
role="CRA",
|
|
endpoint_key="GET:/subjects",
|
|
allowed=True,
|
|
)
|
|
post_perm = ApiEndpointPermission(
|
|
study_id=study_id,
|
|
role="CRA",
|
|
endpoint_key="POST:/subjects",
|
|
allowed=False,
|
|
)
|
|
db_session.add(get_perm)
|
|
db_session.add(post_perm)
|
|
await db_session.commit()
|
|
|
|
# 验证权限
|
|
get_result = await role_has_api_permission(
|
|
db_session, study_id, "CRA", "GET:/subjects"
|
|
)
|
|
post_result = await role_has_api_permission(
|
|
db_session, study_id, "CRA", "POST:/subjects"
|
|
)
|
|
|
|
assert get_result is True
|
|
assert post_result is False
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_api_permission_different_roles(db_session: AsyncSession):
|
|
"""测试不同角色的权限独立"""
|
|
study_id = uuid.uuid4()
|
|
|
|
# 创建权限：CRA允许，PV拒绝
|
|
cra_perm = ApiEndpointPermission(
|
|
study_id=study_id,
|
|
role="CRA",
|
|
endpoint_key="POST:/subjects",
|
|
allowed=True,
|
|
)
|
|
pv_perm = ApiEndpointPermission(
|
|
study_id=study_id,
|
|
role="PV",
|
|
endpoint_key="POST:/subjects",
|
|
allowed=False,
|
|
)
|
|
db_session.add(cra_perm)
|
|
db_session.add(pv_perm)
|
|
await db_session.commit()
|
|
|
|
# 验证权限
|
|
cra_result = await role_has_api_permission(
|
|
db_session, study_id, "CRA", "POST:/subjects"
|
|
)
|
|
pv_result = await role_has_api_permission(
|
|
db_session, study_id, "PV", "POST:/subjects"
|
|
)
|
|
|
|
assert cra_result is True
|
|
assert pv_result is False
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_api_permission_different_studies(db_session: AsyncSession):
|
|
"""测试不同项目的权限独立"""
|
|
study_id_1 = uuid.uuid4()
|
|
study_id_2 = uuid.uuid4()
|
|
|
|
# 创建权限：项目1允许，项目2拒绝
|
|
perm_1 = ApiEndpointPermission(
|
|
study_id=study_id_1,
|
|
role="CRA",
|
|
endpoint_key="POST:/subjects",
|
|
allowed=True,
|
|
)
|
|
perm_2 = ApiEndpointPermission(
|
|
study_id=study_id_2,
|
|
role="CRA",
|
|
endpoint_key="POST:/subjects",
|
|
allowed=False,
|
|
)
|
|
db_session.add(perm_1)
|
|
db_session.add(perm_2)
|
|
await db_session.commit()
|
|
|
|
# 验证权限
|
|
result_1 = await role_has_api_permission(
|
|
db_session, study_id_1, "CRA", "POST:/subjects"
|
|
)
|
|
result_2 = await role_has_api_permission(
|
|
db_session, study_id_2, "CRA", "POST:/subjects"
|
|
)
|
|
|
|
assert result_1 is True
|
|
assert result_2 is False
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_api_permission_none_role(db_session: AsyncSession):
|
|
"""测试None角色的权限检查"""
|
|
study_id = uuid.uuid4()
|
|
|
|
result = await role_has_api_permission(
|
|
db_session, study_id, None, "POST:/subjects"
|
|
)
|
|
assert result is False
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_api_permission_unknown_endpoint(db_session: AsyncSession):
|
|
"""测试未知端点的权限检查"""
|
|
study_id = uuid.uuid4()
|
|
|
|
result = await role_has_api_permission(
|
|
db_session, study_id, "CRA", "POST:/unknown-endpoint"
|
|
)
|
|
assert result is False
|