3630b9000f
## 核心改进
- 完全迁移到接口级权限(68个API端点)
- 实现前置权限检查机制,解决跨模块数据访问权限问题
- 添加权限管理API端点,支持前置权限查询
## 关键变更
1. 权限配置系统
- 添加OPERATION_PREREQUISITES映射表
- 所有操作配置前置权限依赖
2. 权限检查函数
- role_has_api_permission()支持前置权限检查
- get_missing_prerequisites()获取缺失权限列表
3. 权限管理API
- GET /api-permissions/operations - 获取所有操作及前置权限
- GET /api-permissions/operations/prerequisites - 获取前置权限依赖
- GET /api-permissions/{endpoint_key}/prerequisites - 检查缺失权限
4. API端点迁移
- 第1批:subjects, visits, aes, monitoring_visit_issues (23个)
- 第2批:members, sites, project_milestones (11个)
- 第3批:finance_contracts, fees_contracts, drug_shipments (15个)
- 第4批:startup endpoints (19个)
## 测试验证
- 单元测试:24个测试全部通过
- 集成测试:22个迁移端点测试通过
- 前置权限测试:12个测试全部通过
- 总计:46个测试全部通过
## 向后兼容性
- 模块级权限表保留用于历史数据
- 接口级权限未配置时自动回退到模块级权限
- 现有权限配置继续有效
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
346 lines
9.6 KiB
Python
346 lines
9.6 KiB
Python
"""单元测试:前置权限检查"""
|
|
|
|
import pytest
|
|
import uuid
|
|
from sqlalchemy.ext.asyncio import AsyncSession
|
|
|
|
from app.core.project_permissions import (
|
|
role_has_api_permission,
|
|
get_missing_prerequisites,
|
|
)
|
|
from app.models.api_endpoint_permission import ApiEndpointPermission
|
|
from app.models.study_role_permission import StudyRolePermission
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_prerequisite_permission_satisfied(db_session: AsyncSession):
|
|
"""测试前置权限满足的情况"""
|
|
study_id = uuid.uuid4()
|
|
|
|
# 创建权限:主权限 + 前置权限都允许
|
|
main_perm = ApiEndpointPermission(
|
|
study_id=study_id,
|
|
role="CRA",
|
|
endpoint_key="subjects:create",
|
|
allowed=True,
|
|
)
|
|
prereq_perm = ApiEndpointPermission(
|
|
study_id=study_id,
|
|
role="CRA",
|
|
endpoint_key="sites:read",
|
|
allowed=True,
|
|
)
|
|
db_session.add(main_perm)
|
|
db_session.add(prereq_perm)
|
|
await db_session.commit()
|
|
|
|
# 验证权限(包含前置权限检查)
|
|
result = await role_has_api_permission(
|
|
db_session, study_id, "CRA", "subjects:create", check_prerequisites=True
|
|
)
|
|
assert result is True
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_prerequisite_permission_missing(db_session: AsyncSession):
|
|
"""测试前置权限缺失的情况"""
|
|
study_id = uuid.uuid4()
|
|
|
|
# 创建权限:主权限允许,但前置权限不允许
|
|
main_perm = ApiEndpointPermission(
|
|
study_id=study_id,
|
|
role="CRA",
|
|
endpoint_key="subjects:create",
|
|
allowed=True,
|
|
)
|
|
prereq_perm = ApiEndpointPermission(
|
|
study_id=study_id,
|
|
role="CRA",
|
|
endpoint_key="sites:read",
|
|
allowed=False,
|
|
)
|
|
db_session.add(main_perm)
|
|
db_session.add(prereq_perm)
|
|
await db_session.commit()
|
|
|
|
# 验证权限(包含前置权限检查)
|
|
result = await role_has_api_permission(
|
|
db_session, study_id, "CRA", "subjects:create", check_prerequisites=True
|
|
)
|
|
assert result is False
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_prerequisite_permission_not_configured(db_session: AsyncSession):
|
|
"""测试前置权限未配置的情况"""
|
|
study_id = uuid.uuid4()
|
|
|
|
# 创建权限:主权限允许,前置权限未配置
|
|
main_perm = ApiEndpointPermission(
|
|
study_id=study_id,
|
|
role="CRA",
|
|
endpoint_key="subjects:create",
|
|
allowed=True,
|
|
)
|
|
db_session.add(main_perm)
|
|
await db_session.commit()
|
|
|
|
# 验证权限(包含前置权限检查)
|
|
result = await role_has_api_permission(
|
|
db_session, study_id, "CRA", "subjects:create", check_prerequisites=True
|
|
)
|
|
assert result is False
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_multiple_prerequisites_all_satisfied(db_session: AsyncSession):
|
|
"""测试多个前置权限都满足的情况"""
|
|
study_id = uuid.uuid4()
|
|
|
|
# 创建权限:主权限 + 所有前置权限都允许
|
|
main_perm = ApiEndpointPermission(
|
|
study_id=study_id,
|
|
role="CRA",
|
|
endpoint_key="visits:create",
|
|
allowed=True,
|
|
)
|
|
prereq1 = ApiEndpointPermission(
|
|
study_id=study_id,
|
|
role="CRA",
|
|
endpoint_key="subjects:read",
|
|
allowed=True,
|
|
)
|
|
prereq2 = ApiEndpointPermission(
|
|
study_id=study_id,
|
|
role="CRA",
|
|
endpoint_key="sites:read",
|
|
allowed=True,
|
|
)
|
|
db_session.add(main_perm)
|
|
db_session.add(prereq1)
|
|
db_session.add(prereq2)
|
|
await db_session.commit()
|
|
|
|
# 验证权限
|
|
result = await role_has_api_permission(
|
|
db_session, study_id, "CRA", "visits:create", check_prerequisites=True
|
|
)
|
|
assert result is True
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_multiple_prerequisites_one_missing(db_session: AsyncSession):
|
|
"""测试多个前置权限中有一个缺失的情况"""
|
|
study_id = uuid.uuid4()
|
|
|
|
# 创建权限:主权限允许,但其中一个前置权限不允许
|
|
main_perm = ApiEndpointPermission(
|
|
study_id=study_id,
|
|
role="CRA",
|
|
endpoint_key="visits:create",
|
|
allowed=True,
|
|
)
|
|
prereq1 = ApiEndpointPermission(
|
|
study_id=study_id,
|
|
role="CRA",
|
|
endpoint_key="subjects:read",
|
|
allowed=True,
|
|
)
|
|
prereq2 = ApiEndpointPermission(
|
|
study_id=study_id,
|
|
role="CRA",
|
|
endpoint_key="sites:read",
|
|
allowed=False,
|
|
)
|
|
db_session.add(main_perm)
|
|
db_session.add(prereq1)
|
|
db_session.add(prereq2)
|
|
await db_session.commit()
|
|
|
|
# 验证权限
|
|
result = await role_has_api_permission(
|
|
db_session, study_id, "CRA", "visits:create", check_prerequisites=True
|
|
)
|
|
assert result is False
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_get_missing_prerequisites_empty(db_session: AsyncSession):
|
|
"""测试获取缺失的前置权限 - 无缺失"""
|
|
study_id = uuid.uuid4()
|
|
|
|
# 创建权限:所有权限都允许
|
|
main_perm = ApiEndpointPermission(
|
|
study_id=study_id,
|
|
role="CRA",
|
|
endpoint_key="subjects:create",
|
|
allowed=True,
|
|
)
|
|
prereq_perm = ApiEndpointPermission(
|
|
study_id=study_id,
|
|
role="CRA",
|
|
endpoint_key="sites:read",
|
|
allowed=True,
|
|
)
|
|
db_session.add(main_perm)
|
|
db_session.add(prereq_perm)
|
|
await db_session.commit()
|
|
|
|
# 获取缺失的前置权限
|
|
missing = await get_missing_prerequisites(
|
|
db_session, study_id, "CRA", "subjects:create"
|
|
)
|
|
assert missing == []
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_get_missing_prerequisites_single(db_session: AsyncSession):
|
|
"""测试获取缺失的前置权限 - 单个缺失"""
|
|
study_id = uuid.uuid4()
|
|
|
|
# 创建权限:前置权限不允许
|
|
main_perm = ApiEndpointPermission(
|
|
study_id=study_id,
|
|
role="CRA",
|
|
endpoint_key="subjects:create",
|
|
allowed=True,
|
|
)
|
|
prereq_perm = ApiEndpointPermission(
|
|
study_id=study_id,
|
|
role="CRA",
|
|
endpoint_key="sites:read",
|
|
allowed=False,
|
|
)
|
|
db_session.add(main_perm)
|
|
db_session.add(prereq_perm)
|
|
await db_session.commit()
|
|
|
|
# 获取缺失的前置权限
|
|
missing = await get_missing_prerequisites(
|
|
db_session, study_id, "CRA", "subjects:create"
|
|
)
|
|
assert missing == ["sites:read"]
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_get_missing_prerequisites_multiple(db_session: AsyncSession):
|
|
"""测试获取缺失的前置权限 - 多个缺失"""
|
|
study_id = uuid.uuid4()
|
|
|
|
# 创建权限:两个前置权限都不允许
|
|
main_perm = ApiEndpointPermission(
|
|
study_id=study_id,
|
|
role="CRA",
|
|
endpoint_key="visits:create",
|
|
allowed=True,
|
|
)
|
|
prereq1 = ApiEndpointPermission(
|
|
study_id=study_id,
|
|
role="CRA",
|
|
endpoint_key="subjects:read",
|
|
allowed=False,
|
|
)
|
|
prereq2 = ApiEndpointPermission(
|
|
study_id=study_id,
|
|
role="CRA",
|
|
endpoint_key="sites:read",
|
|
allowed=False,
|
|
)
|
|
db_session.add(main_perm)
|
|
db_session.add(prereq1)
|
|
db_session.add(prereq2)
|
|
await db_session.commit()
|
|
|
|
# 获取缺失的前置权限
|
|
missing = await get_missing_prerequisites(
|
|
db_session, study_id, "CRA", "visits:create"
|
|
)
|
|
assert set(missing) == {"subjects:read", "sites:read"}
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_prerequisite_check_disabled(db_session: AsyncSession):
|
|
"""测试禁用前置权限检查"""
|
|
study_id = uuid.uuid4()
|
|
|
|
# 创建权限:主权限允许,前置权限不允许
|
|
main_perm = ApiEndpointPermission(
|
|
study_id=study_id,
|
|
role="CRA",
|
|
endpoint_key="subjects:create",
|
|
allowed=True,
|
|
)
|
|
prereq_perm = ApiEndpointPermission(
|
|
study_id=study_id,
|
|
role="CRA",
|
|
endpoint_key="sites:read",
|
|
allowed=False,
|
|
)
|
|
db_session.add(main_perm)
|
|
db_session.add(prereq_perm)
|
|
await db_session.commit()
|
|
|
|
# 验证权限(禁用前置权限检查)
|
|
result = await role_has_api_permission(
|
|
db_session, study_id, "CRA", "subjects:create", check_prerequisites=False
|
|
)
|
|
assert result is True
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_admin_bypasses_prerequisites(db_session: AsyncSession):
|
|
"""测试ADMIN角色绕过前置权限检查"""
|
|
study_id = uuid.uuid4()
|
|
|
|
# 不创建任何权限
|
|
|
|
# 验证权限(ADMIN应该总是被允许)
|
|
result = await role_has_api_permission(
|
|
db_session, study_id, "ADMIN", "subjects:create", check_prerequisites=True
|
|
)
|
|
assert result is True
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_prerequisite_with_no_prerequisites_operation(db_session: AsyncSession):
|
|
"""测试没有前置权限的操作"""
|
|
study_id = uuid.uuid4()
|
|
|
|
# 创建权限:操作允许(没有前置权限)
|
|
perm = ApiEndpointPermission(
|
|
study_id=study_id,
|
|
role="CRA",
|
|
endpoint_key="sites:read",
|
|
allowed=True,
|
|
)
|
|
db_session.add(perm)
|
|
await db_session.commit()
|
|
|
|
# 验证权限
|
|
result = await role_has_api_permission(
|
|
db_session, study_id, "CRA", "sites:read", check_prerequisites=True
|
|
)
|
|
assert result is True
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_prerequisite_missing_not_configured(db_session: AsyncSession):
|
|
"""测试前置权限未配置时的缺失检查"""
|
|
study_id = uuid.uuid4()
|
|
|
|
# 创建权限:主权限允许,前置权限未配置
|
|
main_perm = ApiEndpointPermission(
|
|
study_id=study_id,
|
|
role="CRA",
|
|
endpoint_key="subjects:create",
|
|
allowed=True,
|
|
)
|
|
db_session.add(main_perm)
|
|
await db_session.commit()
|
|
|
|
# 获取缺失的前置权限
|
|
missing = await get_missing_prerequisites(
|
|
db_session, study_id, "CRA", "subjects:create"
|
|
)
|
|
assert "sites:read" in missing
|