release(main): 修复云端台账保存与备份重开
Storage Persistence Guard / storage-persistence-audit (push) Has been cancelled
Client Quality Gates / Shared client and Web (pull_request) Has been cancelled
Client Quality Gates / macOS Desktop (pull_request) Has been cancelled
Storage Persistence Guard / storage-persistence-audit (pull_request) Has been cancelled
Storage Persistence Guard / storage-persistence-audit (push) Has been cancelled
Client Quality Gates / Shared client and Web (pull_request) Has been cancelled
Client Quality Gates / macOS Desktop (pull_request) Has been cancelled
Storage Persistence Guard / storage-persistence-audit (pull_request) Has been cancelled
This commit is contained in:
@@ -4,7 +4,7 @@ import uuid
|
||||
import zipfile
|
||||
from datetime import datetime, timedelta, timezone
|
||||
from types import SimpleNamespace
|
||||
from unittest.mock import ANY, AsyncMock
|
||||
from unittest.mock import ANY, AsyncMock, call
|
||||
|
||||
import pytest
|
||||
from fastapi import HTTPException
|
||||
@@ -304,6 +304,18 @@ def test_result_download_url_is_restricted_and_public_proxy_urls_are_rewritten(m
|
||||
assert onlyoffice_collaboration_service._validate_result_url(
|
||||
"http://localhost:8888/onlyoffice/cache/result.docx?token=signed"
|
||||
) == "http://onlyoffice/cache/result.docx?token=signed"
|
||||
with pytest.raises(HTTPException) as mismatched_origin:
|
||||
onlyoffice_collaboration_service._validate_result_url(
|
||||
"https://ctms.example.com/onlyoffice/cache/result.xlsx?token=signed"
|
||||
)
|
||||
assert mismatched_origin.value.status_code == 422
|
||||
|
||||
monkeypatch.setattr(settings, "FRONTEND_PUBLIC_URL", "https://ctms.example.com")
|
||||
assert onlyoffice_collaboration_service._validate_result_url(
|
||||
"https://ctms.example.com/onlyoffice/cache/result.xlsx?token=signed"
|
||||
) == "http://onlyoffice/cache/result.xlsx?token=signed"
|
||||
|
||||
monkeypatch.setattr(settings, "FRONTEND_PUBLIC_URL", "http://localhost:8888")
|
||||
for value in (
|
||||
"http://backend:8000/internal/file",
|
||||
"http://onlyoffice.evil.example/cache/result.docx",
|
||||
@@ -384,6 +396,89 @@ async def test_forgotten_document_command_rejects_a_damaged_backup(monkeypatch):
|
||||
assert error.value.status_code == 502
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_document_server_info_command_returns_unique_live_users(monkeypatch):
|
||||
key = "ctms-collab-live-key"
|
||||
request = {}
|
||||
|
||||
class FakeResponse:
|
||||
status_code = 200
|
||||
|
||||
@staticmethod
|
||||
def json():
|
||||
return {"error": 0, "key": key, "users": ["user-1", "user-1", "user-2"]}
|
||||
|
||||
class FakeClient:
|
||||
async def __aenter__(self):
|
||||
return self
|
||||
|
||||
async def __aexit__(self, *_args):
|
||||
return None
|
||||
|
||||
async def post(self, url, *, params, json):
|
||||
request.update(url=url, params=params, body=json)
|
||||
return FakeResponse()
|
||||
|
||||
monkeypatch.setattr(
|
||||
onlyoffice_collaboration_service.httpx,
|
||||
"AsyncClient",
|
||||
lambda **_kwargs: FakeClient(),
|
||||
)
|
||||
|
||||
users = await onlyoffice_collaboration_service._document_server_users(key)
|
||||
|
||||
assert users == ["user-1", "user-2"]
|
||||
assert request["url"] == "http://onlyoffice/command"
|
||||
assert request["params"] == {"shardkey": key}
|
||||
assert jwt.decode(
|
||||
request["body"]["token"], settings.ONLYOFFICE_JWT_SECRET, algorithms=["HS256"]
|
||||
) == {"c": "info", "key": key}
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_document_server_info_command_treats_unknown_key_as_no_live_users(monkeypatch):
|
||||
class FakeResponse:
|
||||
status_code = 200
|
||||
|
||||
@staticmethod
|
||||
def json():
|
||||
return {"error": 1}
|
||||
|
||||
class FakeClient:
|
||||
async def __aenter__(self):
|
||||
return self
|
||||
|
||||
async def __aexit__(self, *_args):
|
||||
return None
|
||||
|
||||
async def post(self, *_args, **_kwargs):
|
||||
return FakeResponse()
|
||||
|
||||
monkeypatch.setattr(
|
||||
onlyoffice_collaboration_service.httpx,
|
||||
"AsyncClient",
|
||||
lambda **_kwargs: FakeClient(),
|
||||
)
|
||||
|
||||
assert await onlyoffice_collaboration_service._document_server_users("retired-key") == []
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_live_editing_session_check_filters_stale_active_rows(monkeypatch):
|
||||
rows = SimpleNamespace(all=lambda: [
|
||||
("live-key", "正在编辑.xlsx"),
|
||||
("stale-key", "陈旧记录.xlsx"),
|
||||
])
|
||||
db = SimpleNamespace(execute=AsyncMock(return_value=rows))
|
||||
lookup = AsyncMock(side_effect=[["user-1", "user-2"], []])
|
||||
monkeypatch.setattr(onlyoffice_collaboration_service, "_document_server_users", lookup)
|
||||
|
||||
active = await onlyoffice_collaboration_service.list_live_editing_sessions(db)
|
||||
|
||||
assert active == [("正在编辑.xlsx", 2)]
|
||||
assert lookup.await_args_list == [call("live-key"), call("stale-key")]
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_editor_config_grants_edit_only_after_collaboration_permission(monkeypatch, tmp_path):
|
||||
user_id = uuid.uuid4()
|
||||
|
||||
@@ -1,7 +1,7 @@
|
||||
import io
|
||||
import uuid
|
||||
import zipfile
|
||||
from datetime import timezone
|
||||
from datetime import datetime, timezone
|
||||
from pathlib import Path
|
||||
from types import SimpleNamespace
|
||||
from unittest.mock import AsyncMock
|
||||
@@ -44,6 +44,7 @@ async def env(monkeypatch, tmp_path):
|
||||
monkeypatch.setattr(collaboration, "COLLABORATION_ROOT", tmp_path)
|
||||
monkeypatch.setattr(settings, "ONLYOFFICE_JWT_SECRET", "ledger-test-secret-long-enough-for-tests")
|
||||
monkeypatch.setattr(onlyoffice_service, "ensure_onlyoffice_available", AsyncMock())
|
||||
monkeypatch.setattr(office, "_document_server_users", AsyncMock(return_value=["live-user"]))
|
||||
async with AsyncSession(engine, expire_on_commit=False) as db:
|
||||
users = [User(id=uuid.uuid4(), email=f"ledger-{i}@example.com", password_hash="hash",
|
||||
full_name=f"Ledger user {i}", clinical_department="test", is_admin=i == 0,
|
||||
@@ -121,6 +122,76 @@ async def test_failed_ledger_session_recovers_server_backup_under_a_new_document
|
||||
recovery.assert_awaited_once_with(failed.document_key, "cell")
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_closed_ledger_session_starts_a_new_key_instead_of_reopening_server_cache(env, monkeypatch):
|
||||
item = await env.db.get(CollaborationFile, env.initial[0].id)
|
||||
first = await office.build_editor_config(env.db, item, env.admin)
|
||||
closed = await env.db.scalar(select(CollaborationSession).where(
|
||||
CollaborationSession.file_id == item.id,
|
||||
CollaborationSession.generation == item.generation,
|
||||
))
|
||||
await office.process_callback(env.db, closed.id, CollaborationCallbackPayload(
|
||||
key=closed.document_key,
|
||||
status=4,
|
||||
))
|
||||
recovery = AsyncMock(return_value=None)
|
||||
monkeypatch.setattr(office, "_recover_forgotten_content", recovery)
|
||||
|
||||
reopened = await office.build_editor_config(env.db, item, env.admin)
|
||||
await env.db.refresh(item)
|
||||
await env.db.refresh(closed)
|
||||
sessions = (await env.db.scalars(select(CollaborationSession).where(
|
||||
CollaborationSession.file_id == item.id,
|
||||
).order_by(CollaborationSession.generation))).all()
|
||||
|
||||
assert first.config["document"]["key"] != reopened.config["document"]["key"]
|
||||
assert item.generation == 2
|
||||
assert closed.status == "CLOSED"
|
||||
assert [session.generation for session in sessions] == [1, 2]
|
||||
recovery.assert_not_awaited()
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_stale_active_ledger_session_starts_a_new_key_when_document_server_has_no_users(
|
||||
env, monkeypatch
|
||||
):
|
||||
item = await env.db.get(CollaborationFile, env.initial[0].id)
|
||||
first = await office.build_editor_config(env.db, item, env.admin)
|
||||
stale = await env.db.scalar(select(CollaborationSession).where(
|
||||
CollaborationSession.file_id == item.id,
|
||||
CollaborationSession.generation == item.generation,
|
||||
))
|
||||
stale.last_callback_at = datetime.now(timezone.utc)
|
||||
await env.db.commit()
|
||||
live_users = AsyncMock(return_value=[])
|
||||
recovery = AsyncMock(return_value=None)
|
||||
monkeypatch.setattr(office, "_document_server_users", live_users)
|
||||
monkeypatch.setattr(office, "_recover_forgotten_content", recovery)
|
||||
|
||||
reopened = await office.build_editor_config(env.db, item, env.admin)
|
||||
await env.db.refresh(item)
|
||||
await env.db.refresh(stale)
|
||||
|
||||
assert first.config["document"]["key"] != reopened.config["document"]["key"]
|
||||
assert item.generation == 2
|
||||
assert stale.status == "CLOSED"
|
||||
live_users.assert_awaited_once_with(stale.document_key)
|
||||
recovery.assert_awaited_once_with(stale.document_key, "cell")
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_new_active_session_is_reused_during_browser_connection_grace(env, monkeypatch):
|
||||
item = await env.db.get(CollaborationFile, env.initial[0].id)
|
||||
first = await office.build_editor_config(env.db, item, env.admin)
|
||||
live_users = AsyncMock(return_value=[])
|
||||
monkeypatch.setattr(office, "_document_server_users", live_users)
|
||||
|
||||
repeated = await office.build_editor_config(env.db, item, env.admin)
|
||||
|
||||
assert first.config["document"]["key"] == repeated.config["document"]["key"]
|
||||
live_users.assert_not_awaited()
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_account_grants_are_independent_and_all_file_routes_require_access(env):
|
||||
await grant(env, env.editor, "EDITOR")
|
||||
|
||||
Reference in New Issue
Block a user