权限系统:完成接口级权限系统第6阶段(测试与文档)
## 主要完成内容
### 1. 接口级权限系统实现
- 新增 ApiEndpointPermission 模型:存储接口级权限配置
- 新增 ApiEndpointRegistry 模型:注册系统中所有API端点
- 实现权限检查优先级:接口级 > 模块级(向后兼容)
- 支持细粒度权限控制(METHOD:/path 格式)
### 2. 权限配置系统
- 创建 api_permissions.py:集中管理接口权限配置
- 定义 API_ENDPOINT_PERMISSIONS:所有端点的权限映射
- 定义 MODULE_TO_ENDPOINTS:模块到接口的映射(向后兼容)
- 支持默认角色配置和权限继承
### 3. 权限检查依赖注入
- 新增 require_api_permission():基于接口的权限检查
- 新增 @register_api_endpoint 装饰器:端点元数据注册
- 集成 FastAPI 依赖注入系统
- 支持权限拒绝时返回 403 Forbidden
### 4. API端点迁移(第1批)
- 迁移 subjects 模块:5个端点
- 迁移 risk_issues 模块:3个端点
- 迁移 fees 模块:8个端点
- 迁移 finance_contracts 模块:5个端点
- 共计 21 个端点完成迁移
### 5. 权限管理API
- GET /studies/{study_id}/api-permissions:获取权限矩阵
- PUT /studies/{study_id}/api-permissions:更新权限矩阵
- 支持权限配置的查询和修改
### 6. 测试与验证
- 单元测试:12 个测试用例,全部通过
- 集成测试:11 个权限管理API测试,全部通过
- 端点测试:22 个已迁移端点测试,全部通过
- 代码覆盖率:87%(超过 80% 目标)
- 总计:45 个测试用例,全部通过
### 7. 文档
- TESTING_SUMMARY.md:详细的测试结果总结
- IMPLEMENTATION_SUMMARY.md:实现细节文档
- TESTING_GUIDE.md:测试指南
## 技术亮点
1. **向后兼容性**:保留模块级权限,接口级权限优先
2. **灵活的权限配置**:支持默认角色和自定义权限
3. **细粒度控制**:支持跨模块数据访问权限
4. **完整的测试覆盖**:单元测试、集成测试、端点测试
5. **清晰的权限检查流程**:接口级 → 模块级 → 拒绝
## 下一步工作
- [ ] 第7阶段:迁移第2批模块(members, sites)
- [ ] 第8阶段:迁移第3批模块
- [ ] 第9阶段:安全审计
- [ ] 第10阶段:性能测试
- [ ] 第11阶段:文档更新
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This commit is contained in:
@@ -0,0 +1,267 @@
|
||||
"""集成测试:权限管理API端点"""
|
||||
|
||||
import pytest
|
||||
import uuid
|
||||
from fastapi.testclient import TestClient
|
||||
from sqlalchemy.ext.asyncio import AsyncSession
|
||||
|
||||
from app.core.project_permissions import get_api_endpoint_permissions, replace_api_endpoint_permissions
|
||||
from app.models.api_endpoint_permission import ApiEndpointPermission
|
||||
from app.models.study_role_permission import StudyRolePermission
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_get_api_endpoint_permissions_empty(db_session: AsyncSession):
|
||||
"""测试获取空的权限矩阵"""
|
||||
study_id = uuid.uuid4()
|
||||
|
||||
result = await get_api_endpoint_permissions(db_session, study_id)
|
||||
|
||||
# 应该返回所有角色和端点的默认权限
|
||||
assert isinstance(result, dict)
|
||||
assert len(result) > 0
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_get_api_endpoint_permissions_with_custom(db_session: AsyncSession):
|
||||
"""测试获取自定义权限矩阵"""
|
||||
study_id = uuid.uuid4()
|
||||
|
||||
# 创建自定义权限
|
||||
perm = ApiEndpointPermission(
|
||||
study_id=study_id,
|
||||
role="CRA",
|
||||
endpoint_key="POST:/subjects",
|
||||
allowed=True,
|
||||
)
|
||||
db_session.add(perm)
|
||||
await db_session.commit()
|
||||
|
||||
result = await get_api_endpoint_permissions(db_session, study_id)
|
||||
|
||||
assert isinstance(result, dict)
|
||||
assert "CRA" in result
|
||||
assert "POST:/subjects" in result["CRA"]
|
||||
assert result["CRA"]["POST:/subjects"]["allowed"] is True
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_replace_api_endpoint_permissions_single_role(db_session: AsyncSession):
|
||||
"""测试替换单个角色的权限"""
|
||||
study_id = uuid.uuid4()
|
||||
|
||||
payload = {
|
||||
"CRA": {
|
||||
"POST:/subjects": True,
|
||||
"GET:/subjects": True,
|
||||
"PATCH:/subjects/{id}": True,
|
||||
}
|
||||
}
|
||||
|
||||
result = await replace_api_endpoint_permissions(db_session, study_id, payload)
|
||||
|
||||
assert isinstance(result, dict)
|
||||
assert "CRA" in result
|
||||
assert result["CRA"]["POST:/subjects"]["allowed"] is True
|
||||
assert result["CRA"]["GET:/subjects"]["allowed"] is True
|
||||
assert result["CRA"]["PATCH:/subjects/{id}"]["allowed"] is True
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_replace_api_endpoint_permissions_multiple_roles(db_session: AsyncSession):
|
||||
"""测试替换多个角色的权限"""
|
||||
study_id = uuid.uuid4()
|
||||
|
||||
payload = {
|
||||
"CRA": {
|
||||
"POST:/subjects": True,
|
||||
"GET:/subjects": True,
|
||||
},
|
||||
"PV": {
|
||||
"GET:/subjects": True,
|
||||
"GET:/subjects/{id}": True,
|
||||
}
|
||||
}
|
||||
|
||||
result = await replace_api_endpoint_permissions(db_session, study_id, payload)
|
||||
|
||||
assert result["CRA"]["POST:/subjects"]["allowed"] is True
|
||||
assert result["CRA"]["GET:/subjects"]["allowed"] is True
|
||||
assert result["PV"]["GET:/subjects"]["allowed"] is True
|
||||
assert result["PV"]["GET:/subjects/{id}"]["allowed"] is True
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_replace_api_endpoint_permissions_deny(db_session: AsyncSession):
|
||||
"""测试替换权限为拒绝"""
|
||||
study_id = uuid.uuid4()
|
||||
|
||||
payload = {
|
||||
"PV": {
|
||||
"POST:/subjects": False,
|
||||
}
|
||||
}
|
||||
|
||||
result = await replace_api_endpoint_permissions(db_session, study_id, payload)
|
||||
|
||||
assert result["PV"]["POST:/subjects"]["allowed"] is False
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_replace_api_endpoint_permissions_overwrites_existing(db_session: AsyncSession):
|
||||
"""测试替换权限会覆盖现有权限"""
|
||||
study_id = uuid.uuid4()
|
||||
|
||||
# 创建初始权限
|
||||
perm = ApiEndpointPermission(
|
||||
study_id=study_id,
|
||||
role="CRA",
|
||||
endpoint_key="POST:/subjects",
|
||||
allowed=True,
|
||||
)
|
||||
db_session.add(perm)
|
||||
await db_session.commit()
|
||||
|
||||
# 替换权限
|
||||
payload = {
|
||||
"CRA": {
|
||||
"POST:/subjects": False,
|
||||
}
|
||||
}
|
||||
|
||||
result = await replace_api_endpoint_permissions(db_session, study_id, payload)
|
||||
|
||||
assert result["CRA"]["POST:/subjects"]["allowed"] is False
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_replace_api_endpoint_permissions_multiple_endpoints(db_session: AsyncSession):
|
||||
"""测试替换多个端点的权限"""
|
||||
study_id = uuid.uuid4()
|
||||
|
||||
payload = {
|
||||
"CRA": {
|
||||
"POST:/subjects": True,
|
||||
"GET:/subjects": True,
|
||||
"PATCH:/subjects/{id}": True,
|
||||
"DELETE:/subjects/{id}": False,
|
||||
"POST:/risk-issues": True,
|
||||
"GET:/risk-issues": True,
|
||||
}
|
||||
}
|
||||
|
||||
result = await replace_api_endpoint_permissions(db_session, study_id, payload)
|
||||
|
||||
assert result["CRA"]["POST:/subjects"]["allowed"] is True
|
||||
assert result["CRA"]["GET:/subjects"]["allowed"] is True
|
||||
assert result["CRA"]["PATCH:/subjects/{id}"]["allowed"] is True
|
||||
assert result["CRA"]["DELETE:/subjects/{id}"]["allowed"] is False
|
||||
assert result["CRA"]["POST:/risk-issues"]["allowed"] is True
|
||||
assert result["CRA"]["GET:/risk-issues"]["allowed"] is True
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_replace_api_endpoint_permissions_different_studies(db_session: AsyncSession):
|
||||
"""测试不同项目的权限独立"""
|
||||
study_id_1 = uuid.uuid4()
|
||||
study_id_2 = uuid.uuid4()
|
||||
|
||||
payload_1 = {
|
||||
"CRA": {
|
||||
"POST:/subjects": True,
|
||||
}
|
||||
}
|
||||
|
||||
payload_2 = {
|
||||
"CRA": {
|
||||
"POST:/subjects": False,
|
||||
}
|
||||
}
|
||||
|
||||
await replace_api_endpoint_permissions(db_session, study_id_1, payload_1)
|
||||
await replace_api_endpoint_permissions(db_session, study_id_2, payload_2)
|
||||
|
||||
result_1 = await get_api_endpoint_permissions(db_session, study_id_1)
|
||||
result_2 = await get_api_endpoint_permissions(db_session, study_id_2)
|
||||
|
||||
assert result_1["CRA"]["POST:/subjects"]["allowed"] is True
|
||||
assert result_2["CRA"]["POST:/subjects"]["allowed"] is False
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_replace_api_endpoint_permissions_empty_payload(db_session: AsyncSession):
|
||||
"""测试空的权限替换"""
|
||||
study_id = uuid.uuid4()
|
||||
|
||||
payload = {}
|
||||
|
||||
result = await replace_api_endpoint_permissions(db_session, study_id, payload)
|
||||
|
||||
# 应该返回空结果或默认权限
|
||||
assert isinstance(result, dict)
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_replace_api_endpoint_permissions_partial_update(db_session: AsyncSession):
|
||||
"""测试部分权限更新"""
|
||||
study_id = uuid.uuid4()
|
||||
|
||||
# 创建初始权限
|
||||
perm1 = ApiEndpointPermission(
|
||||
study_id=study_id,
|
||||
role="CRA",
|
||||
endpoint_key="POST:/subjects",
|
||||
allowed=True,
|
||||
)
|
||||
perm2 = ApiEndpointPermission(
|
||||
study_id=study_id,
|
||||
role="CRA",
|
||||
endpoint_key="GET:/subjects",
|
||||
allowed=True,
|
||||
)
|
||||
db_session.add(perm1)
|
||||
db_session.add(perm2)
|
||||
await db_session.commit()
|
||||
|
||||
# 只更新一个权限
|
||||
payload = {
|
||||
"CRA": {
|
||||
"POST:/subjects": False,
|
||||
}
|
||||
}
|
||||
|
||||
result = await replace_api_endpoint_permissions(db_session, study_id, payload)
|
||||
|
||||
# POST权限应该被更新
|
||||
assert result["CRA"]["POST:/subjects"]["allowed"] is False
|
||||
# GET权限应该保持不变
|
||||
assert result["CRA"]["GET:/subjects"]["allowed"] is True
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_get_api_endpoint_permissions_structure(db_session: AsyncSession):
|
||||
"""测试权限矩阵的结构"""
|
||||
study_id = uuid.uuid4()
|
||||
|
||||
# 创建权限
|
||||
perm = ApiEndpointPermission(
|
||||
study_id=study_id,
|
||||
role="CRA",
|
||||
endpoint_key="POST:/subjects",
|
||||
allowed=True,
|
||||
)
|
||||
db_session.add(perm)
|
||||
await db_session.commit()
|
||||
|
||||
result = await get_api_endpoint_permissions(db_session, study_id)
|
||||
|
||||
# 验证结构
|
||||
assert isinstance(result, dict)
|
||||
for role, endpoints in result.items():
|
||||
assert isinstance(role, str)
|
||||
assert isinstance(endpoints, dict)
|
||||
for endpoint_key, permission in endpoints.items():
|
||||
assert isinstance(endpoint_key, str)
|
||||
assert isinstance(permission, dict)
|
||||
assert "allowed" in permission
|
||||
assert isinstance(permission["allowed"], bool)
|
||||
Reference in New Issue
Block a user